Skip to content

Fix proposal generation and knowledge card creation bugs

Edouard Legoupil requested to merge bugfix/proposal-generation-and-knowledge-card-fix into main_dev

Created by: Edouard-Legoupil

This commit fixes two bugs:

  1. Proposal Generation Error: The create-session endpoint was failing with a 500 error due to a NOT NULL constraint violation on the updated_by column in the proposals table. This was fixed by adding the updated_by field to the INSERT statements in the create_session and save_draft functions in backend/api/proposals.py.

  2. Knowledge Card Creation Error: The "Create New Knowledge Card" screen had a ReferenceError: title is not defined, which prevented the "Populate Card Content" and "Save Card" buttons from being enabled. This was fixed by replacing the undefined title variable with the summary state variable in frontend/src/screens/KnowledgeCard/KnowledgeCard.jsx.

  • Does my code meet the quality standards for releasing packages?
  • Does the reviewer have all the information to validate the features/issues without too much research?
  • Does the customer who will validate the associated tickets have the information to do so without wasting time?

Issues to validate to close :

  • issue #

Processed issues to keep open or in progress:

  • issue #

Checklist:

  • Does the package check go local?
  • Does the CI pass?
  • Are the added / fixed features documented, tested?
  • Are the added features / solved problems briefly presented in the PR message?
  • Are the changes related to tickets / issues that I have listed in the commits and in the PR itself?
  • Are the tickets in "review" mode in the Project Tracking Board?
  • Does each ticket, if it is to be closed after acceptance of the PR, contain a comment that tells how to validate it?

Merge request reports