Skip to content

Fix(knowledge): Handle automatic JSON decoding

Edouard Legoupil requested to merge fix/knowledge-card-fallback into main_dev

Created by: Edouard-Legoupil

This commit fixes a TypeError that occurred when fetching knowledge cards. The database driver automatically decodes JSON/JSONB columns into Python dictionaries, which caused json.loads() to fail.

The fix adds a check to ensure that json.loads() is only called if the generated_sections field is a string. This makes the code more robust and handles cases where the data is already a dictionary. This fix is applied to both get_knowledge_cards and get_knowledge_card functions.

  • Does my code meet the quality standards for releasing packages?
  • Does the reviewer have all the information to validate the features/issues without too much research?
  • Does the customer who will validate the associated tickets have the information to do so without wasting time?

Issues to validate to close :

  • issue #

Processed issues to keep open or in progress:

  • issue #

Checklist:

  • Does the package check go local?
  • Does the CI pass?
  • Are the added / fixed features documented, tested?
  • Are the added features / solved problems briefly presented in the PR message?
  • Are the changes related to tickets / issues that I have listed in the commits and in the PR itself?
  • Are the tickets in "review" mode in the Project Tracking Board?
  • Does each ticket, if it is to be closed after acceptance of the PR, contain a comment that tells how to validate it?

Merge request reports