Skip to content

fix: Correctly display completed reviews and fix permissions

Edouard Legoupil requested to merge feature/pending-reviews-ui-updates into main_dev

Created by: Edouard-Legoupil

This commit resolves two issues related to completed reviews:

  1. A 403 Forbidden error when trying to view a completed review.
  2. An incorrect display of the deadline on completed review cards in the dashboard.
  • The get_proposal_for_review endpoint now allows access to completed reviews.

  • The Project.jsx component now correctly hides the deadline for completed reviews and shows the "Review completed" badge.

  • Does my code meet the quality standards for releasing packages?

  • Does the reviewer have all the information to validate the features/issues without too much research?

  • Does the customer who will validate the associated tickets have the information to do so without wasting time?

Issues to validate to close :

  • issue #

Processed issues to keep open or in progress:

  • issue #

Checklist:

  • Does the package check go local?
  • Does the CI pass?
  • Are the added / fixed features documented, tested?
  • Are the added features / solved problems briefly presented in the PR message?
  • Are the changes related to tickets / issues that I have listed in the commits and in the PR itself?
  • Are the tickets in "review" mode in the Project Tracking Board?
  • Does each ticket, if it is to be closed after acceptance of the PR, contain a comment that tells how to validate it?

Merge request reports

Loading