Skip to content

fix: Resolve peer review bug and update UI

Edouard Legoupil requested to merge feature/pending-reviews-ui-updates into main_dev

Created by: Edouard-Legoupil

This commit addresses a bug that caused a 403 Forbidden error when submitting a proposal for peer review, which also resulted in the list of pending reviews being cleared. The authorization logic for the status-history endpoint has been updated to correctly handle permissions for owners, reviewers, and admin roles.

Additionally, this commit includes the following UI improvements for the peer review process:

  • Removes the "..." menu from proposal cards in the "Pending Reviews" tab.

  • Adds a "Review completed" badge with the completion date to proposals that have been reviewed.

  • Disables the comment form on the review page for completed reviews.

  • Does my code meet the quality standards for releasing packages?

  • Does the reviewer have all the information to validate the features/issues without too much research?

  • Does the customer who will validate the associated tickets have the information to do so without wasting time?

Issues to validate to close :

  • issue #

Processed issues to keep open or in progress:

  • issue #

Checklist:

  • Does the package check go local?
  • Does the CI pass?
  • Are the added / fixed features documented, tested?
  • Are the added features / solved problems briefly presented in the PR message?
  • Are the changes related to tickets / issues that I have listed in the commits and in the PR itself?
  • Are the tickets in "review" mode in the Project Tracking Board?
  • Does each ticket, if it is to be closed after acceptance of the PR, contain a comment that tells how to validate it?

Merge request reports