Skip to content

fix: Handle multiple donors and fix template loading bug

Edouard Legoupil requested to merge fix-template-loading into main_dev

Created by: Edouard-Legoupil

This commit addresses feedback on the previous refactoring.

Key changes:

  • Updated the get_available_templates function in backend/core/config.py to be more robust. It now correctly handles different JSON file structures (skipping lists like in sample_templates.json) and supports a one-to-many mapping from donors to templates.

  • The template discovery logic now looks for a donors list within each template file, aligning with the new requirement that a template can be used for multiple donors.

  • All proposal template files (cerf, echo, iom, unhcr) have been updated to use the new donors list format.

  • This resolves the AttributeError: 'list' object has no attribute 'get' that was occurring when the application tried to load the templates.

  • Does my code meet the quality standards for releasing packages?

  • Does the reviewer have all the information to validate the features/issues without too much research?

  • Does the customer who will validate the associated tickets have the information to do so without wasting time?

Issues to validate to close :

  • issue #

Processed issues to keep open or in progress:

  • issue #

Checklist:

  • Does the package check go local?
  • Does the CI pass?
  • Are the added / fixed features documented, tested?
  • Are the added features / solved problems briefly presented in the PR message?
  • Are the changes related to tickets / issues that I have listed in the commits and in the PR itself?
  • Are the tickets in "review" mode in the Project Tracking Board?
  • Does each ticket, if it is to be closed after acceptance of the PR, contain a comment that tells how to validate it?

Merge request reports