Skip to content

Fix: Ensure success alert triggers after content generation

Edouard Legoupil requested to merge fix-kc-polling-alert into main_dev

Created by: Edouard-Legoupil

The polling mechanism in KnowledgeCard.jsx was not reliably triggering the "Content generation completed successfully!" alert modal. The original logic used a fixed number of polling attempts to determine completion, which could fail if the generation took longer than expected.

This commit replaces the timeout-based check with a deterministic one. The polling logic now verifies that all sections defined in the proposal template have been generated before displaying the success message.

Additionally, a timeout has been re-introduced as a fallback. If the content generation does not complete within a reasonable time (3 minutes), a timeout message is displayed to the user, preventing the component from polling indefinitely in case of a backend failure.

  • Does my code meet the quality standards for releasing packages?
  • Does the reviewer have all the information to validate the features/issues without too much research?
  • Does the customer who will validate the associated tickets have the information to do so without wasting time?

Issues to validate to close :

  • issue #

Processed issues to keep open or in progress:

  • issue #

Checklist:

  • Does the package check go local?
  • Does the CI pass?
  • Are the added / fixed features documented, tested?
  • Are the added features / solved problems briefly presented in the PR message?
  • Are the changes related to tickets / issues that I have listed in the commits and in the PR itself?
  • Are the tickets in "review" mode in the Project Tracking Board?
  • Does each ticket, if it is to be closed after acceptance of the PR, contain a comment that tells how to validate it?

Merge request reports

Loading