feat: Display duplicate badges and enable deletion
Created by: Edouard-Legoupil
This commit addresses two issues related to duplicate knowledge cards:
-
Duplicate Badge Display: The "duplicate" badge was not appearing on all relevant cards. This was resolved by:
- Replacing unstable array indices with unique IDs for the
keyprop in theDashboard.jsxrendering loops. This ensures React can correctly track and re-render components. - Correcting the CSS for the
.duplicate-badgeand.delete-buttonto be positioned relative to their parent.cardcomponent, ensuring they appear within each card instead of stacking in a single spot.
- Replacing unstable array indices with unique IDs for the
-
Delete Functionality: Clicking the delete button on a duplicate card resulted in a
405 Method Not Allowederror. This was fixed by implementing theDELETE /knowledge-cards/{card_id}endpoint in the backend (backend/api/knowledge.py), which properly handles the deletion of a knowledge card and its associations.
A console.log has also been added to Dashboard.jsx to help with further debugging if needed.
- Does my code meet the quality standards for releasing packages?
- Does the reviewer have all the information to validate the features/issues without too much research?
- Does the customer who will validate the associated tickets have the information to do so without wasting time?
Issues to validate to close :
-
issue #
Processed issues to keep open or in progress:
-
issue #
Checklist:
-
Does the package check go local? -
Does the CI pass? -
Are the added / fixed features documented, tested? -
Are the added features / solved problems briefly presented in the PR message? -
Are the changes related to tickets / issues that I have listed in the commits and in the PR itself? -
Are the tickets in "review" mode in the Project Tracking Board? -
Does each ticket, if it is to be closed after acceptance of the PR, contain a comment that tells how to validate it?