Skip to content

fix(knowledge-card): Correctly update reference status after PDF upload

Edouard Legoupil requested to merge fix-knowledge-card-error-state into main_dev

Created by: Edouard-Legoupil

This commit fixes a bug where a knowledge card reference would remain in an "error" state even after a new PDF was successfully uploaded to replace a previously failed ingestion.

The fix is two-fold:

  1. Backend: The upload_pdf_reference endpoint in backend/api/knowledge.py now explicitly sets the scraping_error flag to FALSE in the database after a successful file upload and ingestion. This ensures the database accurately reflects the new state of the reference.

  2. Frontend: The handleUploadReference function in frontend/src/screens/KnowledgeCard/KnowledgeCard.jsx has been simplified. The redundant and problematic call to re-ingest the original URL after a file upload has been removed. The component now simply refreshes its data from the server after a successful upload, which is sufficient to display the corrected status to the user.

  • Does my code meet the quality standards for releasing packages?
  • Does the reviewer have all the information to validate the features/issues without too much research?
  • Does the customer who will validate the associated tickets have the information to do so without wasting time?

Issues to validate to close :

  • issue #

Processed issues to keep open or in progress:

  • issue #

Checklist:

  • Does the package check go local?
  • Does the CI pass?
  • Are the added / fixed features documented, tested?
  • Are the added features / solved problems briefly presented in the PR message?
  • Are the changes related to tickets / issues that I have listed in the commits and in the PR itself?
  • Are the tickets in "review" mode in the Project Tracking Board?
  • Does each ticket, if it is to be closed after acceptance of the PR, contain a comment that tells how to validate it?

Merge request reports