Skip to content

feat: Concatenate card name and summary for slugified filename

Edouard Legoupil requested to merge fix-slugify-knowledge-card-filename into main_dev

Created by: Edouard-Legoupil

This commit revises the filename generation for downloaded Word documents of knowledge cards. The filename is now a slugified concatenation of the card's name and its summary, providing a more descriptive and unique identifier.

This is achieved by:

  • Updating the backend in backend/api/knowledge.py to concatenate the card's name and summary before slugifying the result for the Content-Disposition header.

  • Updating the frontend in frontend/src/screens/Knowledge-Card/KnowledgeCard.jsx to use the Content-Disposition header from the backend as the single source of truth for the filename, removing the need for client-side filename generation.

  • Exposing the Content-Disposition header in the backend's CORS configuration in backend/core/middleware.py.

  • Does my code meet the quality standards for releasing packages?

  • Does the reviewer have all the information to validate the features/issues without too much research?

  • Does the customer who will validate the associated tickets have the information to do so without wasting time?

Issues to validate to close :

  • issue #

Processed issues to keep open or in progress:

  • issue #

Checklist:

  • Does the package check go local?
  • Does the CI pass?
  • Are the added / fixed features documented, tested?
  • Are the added features / solved problems briefly presented in the PR message?
  • Are the changes related to tickets / issues that I have listed in the commits and in the PR itself?
  • Are the tickets in "review" mode in the Project Tracking Board?
  • Does each ticket, if it is to be closed after acceptance of the PR, contain a comment that tells how to validate it?

Merge request reports

Loading