Skip to content

This commit includes two main improvements to the backend scripts.

Edouard Legoupil requested to merge feature-deduplicate-and-find-references into main_dev

Created by: Edouard-Legoupil

First, the database connection logic in 2-update_embeddings.py has been refactored to use SQLAlchemy's URL.create method. This prevents connection errors caused by special characters in the database credentials and makes the script more robust.

Second, the 4-find-references.py script has been updated to handle an all argument for the card_type, allowing the user to find references for all card types in a single run. This addresses feedback from a previous code review.

  • Does my code meet the quality standards for releasing packages?
  • Does the reviewer have all the information to validate the features/issues without too much research?
  • Does the customer who will validate the associated tickets have the information to do so without wasting time?

Issues to validate to close :

  • issue #

Processed issues to keep open or in progress:

  • issue #

Checklist:

  • Does the package check go local?
  • Does the CI pass?
  • Are the added / fixed features documented, tested?
  • Are the added features / solved problems briefly presented in the PR message?
  • Are the changes related to tickets / issues that I have listed in the commits and in the PR itself?
  • Are the tickets in "review" mode in the Project Tracking Board?
  • Does each ticket, if it is to be closed after acceptance of the PR, contain a comment that tells how to validate it?

Merge request reports