Skip to content

fix(backend): Handle dict type for generated_sections

Edouard Legoupil requested to merge fix-knowledge-card-update-error into main_dev

Created by: Edouard-Legoupil

The update_knowledge_card_section function would fail with a TypeError if the generated_sections field from the database was already a dictionary, as it would unconditionally try to call json.loads on it.

This change adds a check to see if generated_sections is a string before attempting to deserialize it, aligning its behavior with other functions in the same file that handle this field.

  • Does my code meet the quality standards for releasing packages?
  • Does the reviewer have all the information to validate the features/issues without too much research?
  • Does the customer who will validate the associated tickets have the information to do so without wasting time?

Issues to validate to close :

  • issue #

Processed issues to keep open or in progress:

  • issue #

Checklist:

  • Does the package check go local?
  • Does the CI pass?
  • Are the added / fixed features documented, tested?
  • Are the added features / solved problems briefly presented in the PR message?
  • Are the changes related to tickets / issues that I have listed in the commits and in the PR itself?
  • Are the tickets in "review" mode in the Project Tracking Board?
  • Does each ticket, if it is to be closed after acceptance of the PR, contain a comment that tells how to validate it?

Merge request reports