Skip to content

Fix: Correct knowledge card file path and naming

Edouard Legoupil requested to merge fix/knowledge-card-file-saving into main_dev

Created by: Edouard-Legoupil

This commit revises the _save_knowledge_card_content_to_file function in the API to address two issues:

  1. The JSON file was being saved in the wrong directory. The file path has been corrected to save files in the backend/knowledge directory, which is the intended location for CrewAI to source knowledge. This is now done using a path relative to the script file to avoid issues with the current working directory.

  2. The filename has been updated to concatenate the kc-link-type, a human-readable label for the linked entity, and the kc-summary. This makes the files easier to reference and use in other parts of the application.

Additionally, this commit includes fixes to the test suite to ensure that the tests pass with the new changes. This includes adding the necessary table definitions to the test database schema.

  • Does my code meet the quality standards for releasing packages?
  • Does the reviewer have all the information to validate the features/issues without too much research?
  • Does the customer who will validate the associated tickets have the information to do so without wasting time?

Issues to validate to close :

  • issue #

Processed issues to keep open or in progress:

  • issue #

Checklist:

  • Does the package check go local?
  • Does the CI pass?
  • Are the added / fixed features documented, tested?
  • Are the added features / solved problems briefly presented in the PR message?
  • Are the changes related to tickets / issues that I have listed in the commits and in the PR itself?
  • Are the tickets in "review" mode in the Project Tracking Board?
  • Does each ticket, if it is to be closed after acceptance of the PR, contain a comment that tells how to validate it?

Merge request reports