Skip to content

fix: Prevent clearing of Country/Location field on load

Edouard Legoupil requested to merge fix-country-location-display into main_dev

Created by: Edouard-Legoupil

The useEffect hook that manages the 'Country / Location(s)' field was incorrectly clearing the value when a proposal was loaded. This was because the dependency array caused the effect to run on initial data population.

This change modifies the useEffect to only clear the 'Country / Location(s)' field if the selected location is no longer valid after a change in the 'Geographical Scope'. This ensures that when a saved proposal is opened, the value is correctly displayed.

  • Does my code meet the quality standards for releasing packages?
  • Does the reviewer have all the information to validate the features/issues without too much research?
  • Does the customer who will validate the associated tickets have the information to do so without wasting time?

Issues to validate to close :

  • issue #

Processed issues to keep open or in progress:

  • issue #

Checklist:

  • Does the package check go local?
  • Does the CI pass?
  • Are the added / fixed features documented, tested?
  • Are the added features / solved problems briefly presented in the PR message?
  • Are the changes related to tickets / issues that I have listed in the commits and in the PR itself?
  • Are the tickets in "review" mode in the Project Tracking Board?
  • Does each ticket, if it is to be closed after acceptance of the PR, contain a comment that tells how to validate it?

Merge request reports