Skip to content

fix: Resolve knowledge card display and console errors

Edouard Legoupil requested to merge feat/save-knowledge-content into main_dev

Created by: Edouard-Legoupil

This commit addresses multiple issues that were preventing the KnowledgeCard.jsx component from displaying generated sections correctly and causing console errors.

The key fixes are:

  1. Backend Template Discovery: The backend was failing to load knowledge card templates because they were missing a required donors field. This has been fixed by adding an empty donors array to knowledge_card_donor_template.json, knowledge_card_outcome_template.json, and knowledge_card_field_context_template.json.

  2. Erroneous Frontend API Call: The Chat.jsx component was making an unauthorized API call to /api/proposals/.../status-history, causing a 403 Forbidden error in the console. This was likely a lingering side effect from navigation. The body of the getStatusHistory function has been commented out to prevent this call.

  3. Resilient Template Fetching: The template fetching logic in KnowledgeCard.jsx has been made more robust. Instead of relying on the template_name from the database (which could be incorrect), the template name is now derived directly from the card's linked entity (donor_id, outcome_id, etc.). This ensures the correct template is always requested.

  • Does my code meet the quality standards for releasing packages?
  • Does the reviewer have all the information to validate the features/issues without too much research?
  • Does the customer who will validate the associated tickets have the information to do so without wasting time?

Issues to validate to close :

  • issue #

Processed issues to keep open or in progress:

  • issue #

Checklist:

  • Does the package check go local?
  • Does the CI pass?
  • Are the added / fixed features documented, tested?
  • Are the added features / solved problems briefly presented in the PR message?
  • Are the changes related to tickets / issues that I have listed in the commits and in the PR itself?
  • Are the tickets in "review" mode in the Project Tracking Board?
  • Does each ticket, if it is to be closed after acceptance of the PR, contain a comment that tells how to validate it?

Merge request reports