Skip to content

Sync DTE model with updated Link from Jargon.

Michael Nelson requested to merge dia-model-link into main

The diff is larger than the actual change being sync'd. Much of the diff is Jargon's order of output changing a while back.

FWIW, I got anthropic to analyse the diff, the response is below. So the main two one changes are is:

  1. Updating to the new Link model (should have been included in !563 (merged) but somehow I only included the core/dpp link changes there and missed DTE), and
  2. The change of type for the TransactionEvent.sourceParty and destinationParty from an @id to an xsd:string... this is unexpected, I'll leave this MR in draft until I figure out why that change has happened - documented in Jargon issue 69 Resaving after Alastair looked at https://github.com/jargon-sh/issues/issues/69#issuecomment-3850582156 fixed this, removing the unexpected change.

Anthropic analysis of diff

Based on my analysis of the changes.diff file, I can break down the changes into two main categories:

Moving Data (Reorganization/Relocation)

Most of the changes in this diff are moving existing data without modifying the content:

1. TransformationEvent Definition Movement

+    "TransformationEvent": {
+      "@protected": true,
+      "@id": "untp-dte:TransformationEvent",
+      "@context": {
        // ... entire definition moved here

This same complete definition is removed from lines 616-778, showing it was relocated within the same file.

2. Event Schema Movement

The Event definition in the schema file is moved from line 897 to line 160 - same content, different position.

3. Vocabulary Property Reorganization

Several property definitions are repositioned in the vocabulary file:

  • TransformationEvent class definition moved earlier in the file
  • outputEPCList, inputEPCList, inputQuantityList, outputQuantityList properties moved to different positions

Changing Data (Actual Modifications)

The actual content changes are more limited:

1. New Link Class Added

+    "Link": {
+      "@protected": true,
+      "@id": "untp-core:Link",
+      "@context": {
        // ... new structure definition

2. Simplified Link References

  • productImage field: Changed from a full @context definition to just "@type": "@id"
  • furtherInformation field: Same simplification - removed complex @context, replaced with "@type": "@id"

3. Type Changes in Schema

-          "@type": "@id"
+          "@type": "xsd:string"

Both sourceParty and destinationParty changed from @id type to xsd:string type. See above explanation for why this change is no longer present.

4. Added Examples

Example URLs were added for sourceParty and destinationParty fields in the schema.

Summary

~80% Moving Data: The bulk of the diff consists of reorganizing existing definitions within the files - moving TransformationEvent, Event, and various property definitions to different locations without changing their content.

~20% Changing Data: The actual modifications include adding a new Link class, simplifying link reference structures, changing data types for party fields, and adding example values.

This appears to be primarily a refactoring effort to improve organization and structure, with some targeted improvements to the data model.

Edited by Michael Nelson

Merge request reports

Loading