Skip to content

Extract out the change from SecureLink to the VC digestMultibase link.

Michael Nelson requested to merge link-using-vc-digestMultibase into main

I'm extracting this SecureLink/Link change out separately after noting that these unrelated changes were turning up in other merge requests, making them harder to review.

At some point before the repository was moved to unicc gitlab, we'd worked on a change to replace the untp-core custom SecureLink with an upgraded plain Link that used the VC digitalMultibase predicate. See #408 (closed) for more background or 55808091 for the actual commit done then.

The problem was, we'd landed the change to UNTP-core but hadn't yet refreshed the generation of data for the other domains. Additionally, our CI testing didn't pick up that when we added Link.id, we forgot to omit it from the context (since the VCDM2 already defines id globally), since there is not sample data in core to test with - it was only when testing one of the other domains that the issue is seen.

So, this PR:

  • Omits Link.id's definition from the context in core, and
  • Includes the regeneration of the DPP domain with that updated core (ie. with SecureLink removed and replaced by a Link with the digestMultibase).

I'll follow-up with a separate PR for the DPP credentialSubject change, then move on to the other domains with similar PRs.

Edited by Michael Nelson

Merge request reports