Skip to content

fix(lint): resolve all lint and format errors across all components

Jérôme Revillard requested to merge fix-lint into main

Summary

Fixes all linting errors and formatting issues across every component in the project, achieving 0 errors, 0 warnings for JS/Python components and 0 errors for Dart/Flutter.

Changes

Python (genie-ai-overlay/)

  • Fixed 135+ Ruff lint errors (E501, SIM117, E722, E101/W191)
  • Applied Ruff formatting across all Python files

Frontend (gov-chat-frontend/)

  • Added emits declarations to 14 Vue components
  • Fixed vue/no-required-prop-with-default on config prop
  • Added eslint-disable for intentional v-html usage
  • Fixed oidcConfig test scope expectation
  • Applied Prettier formatting

Backend (gov-chat-backend/)

  • Removed unused variables (startDate, parentFolder)
  • Added missing aql import in analytics-service
  • Fixed bare catch clauses
  • Applied Prettier formatting

Document Repository (document-repository/)

  • Removed unused imports and variables
  • Fixed no-control-regex with split().some(charCodeAt())
  • Added { cause: error } to throw statements
  • Removed unused rate limiter code
  • Applied Prettier formatting

Shared Library (shared/lib/)

  • Removed duplicate/shadowed method definitions
  • Removed unused variables across multiple files
  • Fixed prefer-const in aql-parser
  • Removed unnecessary regex escapes
  • Added argsIgnorePattern for underscore-prefixed params
  • Applied Prettier formatting

Mobile (genie_ai_mobile/)

  • Applied dart format across all Flutter source files

Lint Status

Component Before After
Python refactor errors 0 errors, 0 warnings
Frontend ~37 errors + warnings 0 errors, 0 warnings
Backend ~40 errors 0 errors, 0 warnings
Document Repository ~24 errors 0 errors, 0 warnings
Shared Library ~33 errors 0 errors, 0 warnings
Mobile (Dart) formatting 0 errors (19 warnings + 143 info, pre-existing)

Testing

  • Backend: 179 tests passed
  • Document Repository: 117 tests passed
  • Frontend: pre-existing test failures unrelated to lint changes

Related

Edited by Jérôme Revillard

Merge request reports

Loading