Generated context file issues

Created by: Fak3

Issues and notes on https://jargon.sh/user/unece/DigitalProductPassport/v/working/artefacts/jsonldContexts/DigitalProductPassport.jsonld?class=DigitalProductPassport

18 hours ago

"partyName": {
          "@id": "untp-dpp:partyName",
          "@type": "schemaorg:name"
        },

As we discussed above, partyName should be removed. Use name instead which is already defined in VC context (edited)

17 hours ago

"registrationCountry": {
          "@id": "untp-core:registrationCountry",
          "@type": "@vocab",
          "@context": {
            "@protected": true,
            "@vocab": "https://test.uncefact.org/vocabulary/untp/core/countryCode#"
          }
        },

The url this vocab points to returns http error.

17 hours ago

"fileType": {
          "@id": "untp-core:fileType",
          "@type": "@vocab",
          "@context": {
            "@protected": true,
            "@vocab": "https://test.uncefact.org/vocabulary/untp/core/mimeType#"
          }
        }

Does untp project really needs to maintain list of mimetypes in it's vocabulary? I don't see any reason to. Probably better to leave mimetype property as plain string

17 hours ago

"issuingBody": {
          "@id": "untp-dpp:issuingBody",
          "@type": "untp-core:Party"
        },

@type must be @id, this is how context say that property refers to another object. Property range defined in the vocabulary file, not context.

17 hours ago

"volume": {
          "@protected": true,
          "@id": "untp-core:Measure",

@id must be untp-core:volume

17 hours ago

"Claim": {
      "@protected": true,
      "@id": "untp-dpp:Claim",
      "@type": "@id",

Remove @type. It is only used on properties, not classes

17 hours ago "benchmarkValue": "untp-core:Metric" Should be "benchmarkValue": "untp-core:benchmarkValue"

13 hours ago

"DigitalProductPassport": {
      "@protected": true,
      "@id": "untp-dpp:DigitalProductPassport",
      "@type": "@id",
      "@context": {
        "@context": {
          "@id": "untp-dpp:@context",
          "@type": "xsd:string"
        },
        "issuer": {
          "@id": "untp-dpp:issuer",
          "@type": "untp-core:Party"
        },
        "validFrom": {
          "@id": "untp-dpp:validFrom",
          "@type": "xsd:string"
        },
        "validUntil": {
          "@id": "untp-dpp:validUntil",
          "@type": "xsd:string"
        },
        "credentialSubject": {
          "@id": "untp-dpp:credentialSubject",
          "@type": "untp-dpp:ProductPassport"
        }
      }
    }

The entry:

    "@context": {
      "@id": "untp-dpp:@context",
      "@type": "xsd:string"
    }

Needs to be removed here, this is an invalid scoped context.I would personally remove all of the "DigitalProductPassport" properties here since they are just what the "VerifiableCredential" already defines, but it doesn't break anything having them there.Same for the DCC